Conversation
FanWu-ai
marked this pull request as ready for review
October 3, 2026 09:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeepSearch reports matching dictionary keys and attribute names before the recursive search checks exclusions. For example,
DeepSearch({'needle': 'x'}, 'needle', exclude_paths=["root['needle']"])currently reports the excluded path inmatched_paths.Check the child object and its path with the existing exclusion predicate before reporting a path match. Add ten regression cases covering exact, wildcard and regex path exclusions, attribute names, excluded child types, retained siblings, and both verbosity levels.
This complements #629: that change fixes the recursive current-object type check, while this fixes the earlier path-reporting step. All eight initial path-exclusion regressions still fail with #629's production change alone.
Validation on Linux, CPython 3.12.14:
pytest --cov=deepdiff --runslow --benchmark-disable -q: 1,319 passed, 8 skipped; 95% aggregate coverage.deepdiff/search.py.pyright deepdiff/search.py: 0 errors, 0 warnings.E9,F63,F7,F82andgit diff --check: passed.Other Python versions, operating systems, and hosted CI have not been validated locally.