Use umbrellas instead of direct includes in renderer/imagemanager module (#58708) - #58708
Open
j-piasecki wants to merge 4 commits into
Open
j-piasecki wants to merge 4 commits into
j-piasecki wants to merge 4 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122119728. |
meta-codesync
Bot
changed the title
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
…ule (react#58708) Summary: Changelog: [Internal] Part of the C++ stable API migration to umbrella includes. The `renderer/imagemanager` headers included other public modules through their fine-grained, `UmbrellaGuard`-protected headers. They now include those modules' umbrellas instead: `<React/RendererCore.h>`, `<React/Utils.h>`, `<React/Graphics.h>`, `<React/Debug.h>`, `<React/RendererDebug.h>`, `<React/FeatureFlags.h>` and `<React/MapBuffer.h>`. Includes of the module's own headers and all `.cpp`/`.mm` files are unchanged. No functional change. Differential Revision: D122119728
j-piasecki
force-pushed
the
export-D122119728
branch
from
September 29, 2026 07:24
4711f4f to
74ac59c
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
…ule (react#58708) Summary: Changelog: [Internal] Part of the C++ stable API migration to umbrella includes. The `renderer/imagemanager` headers included other public modules through their fine-grained, `UmbrellaGuard`-protected headers. They now include those modules' umbrellas instead: `<React/RendererCore.h>`, `<React/Utils.h>`, `<React/Graphics.h>`, `<React/Debug.h>`, `<React/RendererDebug.h>`, `<React/FeatureFlags.h>` and `<React/MapBuffer.h>`. Includes of the module's own headers and all `.cpp`/`.mm` files are unchanged. No functional change. Differential Revision: D122119728
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
…ule (react#58708) Summary: Changelog: [Internal] Part of the C++ stable API migration to umbrella includes. The `renderer/imagemanager` headers included other public modules through their fine-grained, `UmbrellaGuard`-protected headers. They now include those modules' umbrellas instead: `<React/RendererCore.h>`, `<React/Utils.h>`, `<React/Graphics.h>`, `<React/Debug.h>`, `<React/RendererDebug.h>`, `<React/FeatureFlags.h>` and `<React/MapBuffer.h>`. Includes of the module's own headers and all `.cpp`/`.mm` files are unchanged. No functional change. Differential Revision: D122119728
j-piasecki
force-pushed
the
export-D122119728
branch
from
September 29, 2026 07:36
74ac59c to
7f600b9
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
…ule (react#58708) Summary: Changelog: [Internal] Part of the C++ stable API migration to umbrella includes. The `renderer/imagemanager` headers included other public modules through their fine-grained, `UmbrellaGuard`-protected headers. They now include those modules' umbrellas instead: `<React/RendererCore.h>`, `<React/Utils.h>`, `<React/Graphics.h>`, `<React/Debug.h>`, `<React/RendererDebug.h>`, `<React/FeatureFlags.h>` and `<React/MapBuffer.h>`. Includes of the module's own headers and all `.cpp`/`.mm` files are unchanged. No functional change. Differential Revision: D122119728
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
…ule (react#58708) Summary: Changelog: [Internal] Part of the C++ stable API migration to umbrella includes. The `renderer/imagemanager` headers included other public modules through their fine-grained, `UmbrellaGuard`-protected headers. They now include those modules' umbrellas instead: `<React/RendererCore.h>`, `<React/Utils.h>`, `<React/Graphics.h>`, `<React/Debug.h>`, `<React/RendererDebug.h>`, `<React/FeatureFlags.h>` and `<React/MapBuffer.h>`. Includes of the module's own headers and all `.cpp`/`.mm` files are unchanged. No functional change. Differential Revision: D122119728
j-piasecki
force-pushed
the
export-D122119728
branch
from
September 29, 2026 08:57
7f600b9 to
ae42985
Compare
Summary: Adds a `dangerouslyExposeInPublicCppHeaders` option to the feature flags config. Flags that opt in are generated into `ReactNativePublicFeatureFlags.h`, whose getters forward to `ReactNativeFeatureFlags` from a generated `.cpp`, so exported headers can read them without including the rest of the module. Opts in the flags that exported headers currently read inline. Changelog: [Internal] Differential Revision: D122353811
Summary: Exported headers that read feature flags inline now go through the generated `ReactNativePublicFeatureFlags.h` instead of `ReactNativeFeatureFlags.h`. Sources that relied on the transitive include now include `ReactNativeFeatureFlags.h` directly. Changelog: [Internal] Differential Revision: D122353873
Summary: Moves `react/featureflags` from the public tier of the C++ stable API to the private tier. The `<React/FeatureFlags.h>` umbrella and its build plumbing are removed, and the headers include `PrivateGuard.h` instead of `UmbrellaGuard.h`. Changelog: [Internal] Differential Revision: D122353979
…ule (react#58708) Summary: Pull Request resolved: react#58708 Changelog: [Internal] Part of the C++ stable API migration to umbrella includes. The `renderer/imagemanager` headers included other public modules through their fine-grained, `UmbrellaGuard`-protected headers. They now include those modules' umbrellas instead: `<React/RendererCore.h>`, `<React/Utils.h>`, `<React/Graphics.h>`, `<React/Debug.h>`, `<React/RendererDebug.h>`, `<React/FeatureFlags.h>` and `<React/MapBuffer.h>`. Includes of the module's own headers and all `.cpp`/`.mm` files are unchanged. No functional change. Differential Revision: D122119728
j-piasecki
force-pushed
the
export-D122119728
branch
from
September 30, 2026 08:06
ae42985 to
22e77e9
Compare
cortinico
approved these changes
Sep 30, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Part of the C++ stable API migration to umbrella includes. The
renderer/imagemanagerheaders included other public modules through their fine-grained,UmbrellaGuard-protected headers. They now include those modules' umbrellas instead:<React/RendererCore.h>,<React/Utils.h>,<React/Graphics.h>,<React/Debug.h>,<React/RendererDebug.h>,<React/FeatureFlags.h>and<React/MapBuffer.h>.Includes of the module's own headers and all
.cpp/.mmfiles are unchanged. No functional change.Differential Revision: D122119728