Skip to content

Use public umbrellas in attributedstring headers (#58710) - #58710

Closed
coado wants to merge 1 commit into
react:mainfrom
coado:export-D121793359
Closed

coado wants to merge 1 commit into
react:mainfrom
coado:export-D121793359

Conversation

@coado

@coado coado commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

Migrate React-Fabric attributedstring headers to consume stable Debug, FeatureFlags, CSS, Graphics, MapBuffer, RendererCore, Utils, and View umbrellas instead of guarded leaf headers. Add the direct Buck and CocoaPods dependencies required by those public imports.

Avoid RendererDebug.h because its current utility-template export changes downstream overload lookup; RendererCore already provides the debug declaration types used by attributedstring.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D121793359

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 28, 2026
@facebook-github-tools facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Sep 28, 2026
@meta-codesync

meta-codesync Bot commented Sep 28, 2026

Copy link
Copy Markdown

@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121793359.

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync Bot changed the title Use public umbrellas in attributedstring headers Use public umbrellas in attributedstring headers (#58710) Oct 1, 2026
coado added a commit to coado/react-native that referenced this pull request Oct 1, 2026
Summary:

Migrate React-Fabric attributedstring headers to consume stable Debug, FeatureFlags, CSS, Graphics, MapBuffer, RendererCore, Utils, and View umbrellas instead of guarded leaf headers. Add the direct Buck and CocoaPods dependencies required by those public imports.

Avoid RendererDebug.h because its current utility-template export changes downstream overload lookup; RendererCore already provides the debug declaration types used by attributedstring.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D121793359
@coado
coado force-pushed the export-D121793359 branch from 67b07f8 to 46af343 Compare October 1, 2026 08:33
coado added a commit to coado/react-native that referenced this pull request Oct 1, 2026
Summary:

Migrate React-Fabric attributedstring headers to consume stable Debug, FeatureFlags, CSS, Graphics, MapBuffer, RendererCore, Utils, and View umbrellas instead of guarded leaf headers. Add the direct Buck and CocoaPods dependencies required by those public imports.

Avoid RendererDebug.h because its current utility-template export changes downstream overload lookup; RendererCore already provides the debug declaration types used by attributedstring.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D121793359
coado added a commit to coado/react-native that referenced this pull request Oct 1, 2026
Summary:
Pull Request resolved: react#58710

Migrate React-Fabric attributedstring headers to consume stable Debug, FeatureFlags, CSS, Graphics, MapBuffer, RendererCore, Utils, and View umbrellas instead of guarded leaf headers. Add the direct Buck and CocoaPods dependencies required by those public imports.

Avoid RendererDebug.h because its current utility-template export changes downstream overload lookup; RendererCore already provides the debug declaration types used by attributedstring.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D121793359
@coado
coado force-pushed the export-D121793359 branch from 46af343 to a62c64e Compare October 1, 2026 08:36
coado added a commit to coado/react-native that referenced this pull request Oct 1, 2026
Summary:

Migrate React-Fabric attributedstring headers to consume stable Debug, FeatureFlags, CSS, Graphics, MapBuffer, RendererCore, Utils, and View umbrellas instead of guarded leaf headers. Add the direct Buck and CocoaPods dependencies required by those public imports.

Avoid RendererDebug.h because its current utility-template export changes downstream overload lookup; RendererCore already provides the debug declaration types used by attributedstring.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D121793359
@coado
coado force-pushed the export-D121793359 branch from a62c64e to d44ae88 Compare October 1, 2026 10:56
coado added a commit to coado/react-native that referenced this pull request Oct 1, 2026
Summary:

Migrate React-Fabric attributedstring headers to consume stable Debug, FeatureFlags, CSS, Graphics, MapBuffer, RendererCore, Utils, and View umbrellas instead of guarded leaf headers. Add the direct Buck and CocoaPods dependencies required by those public imports.

Avoid RendererDebug.h because its current utility-template export changes downstream overload lookup; RendererCore already provides the debug declaration types used by attributedstring.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D121793359
coado added a commit to coado/react-native that referenced this pull request Oct 1, 2026
Summary:
Pull Request resolved: react#58710

Migrate React-Fabric attributedstring headers to consume stable Debug, FeatureFlags, CSS, Graphics, MapBuffer, RendererCore, Utils, and View umbrellas instead of guarded leaf headers. Add the direct Buck and CocoaPods dependencies required by those public imports.

Avoid RendererDebug.h because its current utility-template export changes downstream overload lookup; RendererCore already provides the debug declaration types used by attributedstring.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D121793359
@coado
coado force-pushed the export-D121793359 branch from d44ae88 to e7f4275 Compare October 1, 2026 11:00
coado added a commit to coado/react-native that referenced this pull request Oct 1, 2026
Summary:

Migrate React-Fabric attributedstring headers to consume stable Debug, FeatureFlags, CSS, Graphics, MapBuffer, RendererCore, Utils, and View umbrellas instead of guarded leaf headers. Add the direct Buck and CocoaPods dependencies required by those public imports.

Avoid RendererDebug.h because its current utility-template export changes downstream overload lookup; RendererCore already provides the debug declaration types used by attributedstring.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D121793359
@coado
coado force-pushed the export-D121793359 branch from e7f4275 to f671377 Compare October 1, 2026 15:38
coado added a commit to coado/react-native that referenced this pull request Oct 1, 2026
Summary:

Migrate React-Fabric attributedstring headers to consume stable Debug, FeatureFlags, CSS, Graphics, MapBuffer, RendererCore, Utils, and View umbrellas instead of guarded leaf headers. Add the direct Buck and CocoaPods dependencies required by those public imports.

Avoid RendererDebug.h because its current utility-template export changes downstream overload lookup; RendererCore already provides the debug declaration types used by attributedstring.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D121793359
Summary:
Pull Request resolved: react#58710

Migrate React-Fabric attributedstring headers to consume stable Debug, FeatureFlags, CSS, Graphics, MapBuffer, RendererCore, Utils, and View umbrellas instead of guarded leaf headers. Add the direct Buck and CocoaPods dependencies required by those public imports.

Avoid RendererDebug.h because its current utility-template export changes downstream overload lookup; RendererCore already provides the debug declaration types used by attributedstring.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D121793359
@coado
coado force-pushed the export-D121793359 branch from f671377 to 6cb5514 Compare October 1, 2026 15:51
@meta-codesync meta-codesync Bot closed this in 9ea7df2 Oct 2, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Oct 2, 2026
@meta-codesync

meta-codesync Bot commented Oct 2, 2026

Copy link
Copy Markdown

This pull request has been merged in 9ea7df2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants