Guard ArrayBuffer allocation in WithRuntimeDecorator - #58777
Open
JoaoPauloCMarra wants to merge 1 commit into
Open
JoaoPauloCMarra wants to merge 1 commit into
JoaoPauloCMarra wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #58776. ArrayBuffer allocation bypasses the guard supplied to
WithRuntimeDecorator, unlike adjacent methods.Changelog:
[GENERAL] [FIXED] - Enter the runtime guard during ArrayBuffer allocation.
Test Plan:
Two native GTests compiled against main JSI headers and
jsi.cpp: both fail before the fix and pass afterward. Coverage checks allocation under the guard, balanced callbacks on return/throw, and buffer size/data. Pinned C++ formatting passes. The full runtime matrix was not run; API snapshot validation is unavailable becausedoxmlparseris missing. No API signature changed.