Repository navigation
Conversation
Flip global.lightspeed.enabled back to true (values, schema default, README) now that the re-enable ticket RHIDP-15458 is closed and the DPDY catalog-index issue is resolved. All Intelligent Assistant images verified multi-arch (RHIDP-18787): - lightspeed-core/lightspeed-stack-rhel9: manifest list amd64+arm64 - offline-knowledge-portal/rhokp-rhel9: manifest list amd64+arm64 - quay.io/redhat-ai-dev/rag-content (init container): manifest list amd64+arm64 at the pinned tag Signed-off-by: Martin Polasko <mpolasko@redhat.com>
- README: trailing period to match helm-docs output - values.schema.json: flip enabled in the default-values tree to match values.yaml (missed occurrence beside the properties entry) - Chart.yaml: 7.0.99 -> 7.0.100 (ct lint requires a version bump) Signed-off-by: Martin Polasko <mpolasko@redhat.com>
|
|
Collaborator
Author
|
Closing — will be re-opened under the author's own account (the commits on the branch are already authored correctly). Same branch, same changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Flips
global.lightspeed.enabledback totruein the deprecatedcharts/backstagechart (values.yaml, values.schema.json default + default-values tree, README, version bump 7.0.99 → 7.0.100) and removes the stale FIXME referencing RHIDP-15458.Important finding while validating
The new standalone
charts/rhdhchart (v3.5.18, RHDHPLAN-1058) already shipsintelligentAssistant.enabled: true— the disabled default only exists on the deprecatedcharts/backstagechart (disable commit 53117c2, Jul 15, "DPDY issues in next catalog index image"). The midstream values patch (intelligentAssistant.core.image→ lightspeed-stack-rhel9 digest pinning) targets the new chart structure, so the productized 2.2 chart lineage already enables the Intelligent Assistant. This PR is therefore consistency cleanup on the deprecated chart, not the enablement vehicle.Why still worth it
backstagechart gets a consistent default.Multi-arch verification (RHIDP-18787)
registry.redhat.io/lightspeed-core/lightspeed-stack-rhel9:0.6.7registry.redhat.io/offline-knowledge-portal/rhokp-rhel9quay.io/redhat-ai-dev/rag-content:release-1.10-lls-0.5.0-8c231a3b…Notes
ci/with-lightspeed-service-host-values.yamlscenario does not setenabled, so it resumes exercising the enabled path.charts/backstage/ci/with-lightspeed-disabled-values.yamlstill explicitly disables for the negative-path CI scenario (unchanged).Jira: RHIDP-18787, RHIDP-15458