Repository navigation
Add Go 1.26.11 module and move users off Go 1.25 to fix CVE-2026-97040 - #520
Merged
Merged
Conversation
Build the Go module from Go 1.26.11, the first 1.26 release with the fix for CVE-2026-97040 (GO-2026-6851). Go 1.25 gets no fix, so retire go-1.25 and send it, and the unversioned go alias, to go-1.26 through the upgrade map. Assisted-by: Replit
aaronkosel-replit
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CVE-2026-97040 (GO-2026-6851, https://pkg.go.dev/vuln/GO-2026-6851) is a critical bug in the Go toolchain. Building a package that contains a crafted
.sysofile can sneak extra flags into the linker. It is fixed only in Go 1.26.11 and 1.27.4. Go 1.25 and older will not get a fix.Today every Replit workspace that uses Go gets Go 1.25 (1.25.5 from our nixpkgs pin), so users are exposed. Slack discussion: https://replit.slack.com/archives/C03FS477T17/p1794982992131789
What changed
flake.nix: build Go 1.26.11 by taking nixpkgs'go_1_26(which is only 1.26rc1 in our lock) and pointing it at the official 1.26.11 source tarball. A matchingbuildGo126Moduleis built on top of it so gopls is compiled with the same Go.pkgs/modules/default.nix: the Go module now uses that Go 1.26.11 and gopls, so it registers asgo-1.26instead ofgo-1.25.pkgs/upgrade-map/default.nix: the unversionedgoalias andgo-1.25now resolve togo-1.26. Older IDs (go-1.19throughgo-1.24) already chain throughgo-1.25, so they also land on 1.26.pkgs/default.nix: the small dev bundle shipsgo-1.26instead ofgo-1.25.The
go-1.25implementation is removed rather than kept next to 1.26. This follows the README's retirement rule (remove the registration, keep the old ID as an upgrade alias) and the way Go 1.24 was retired. Keeping 1.25 around would leave a version with no security fix available to users.Heads up for reviewers: this changes the Go version for real users. Anyone on
go,go-1.25or an older Go ID gets Go 1.26 the next time they pick up a new bundle. Go keeps strong backwards compatibility, but a project that pins an oldgoortoolchainline or relies on 1.25-only behavior could notice. If you would rather keep 1.25 available for a while, say so and I will add 1.26 alongside it instead.Test plan
nix eval .#moduleslistsgo-1.26as an implementation, withgo,go-1.19togo-1.25as aliases. The registry checks (no shadowing, no cycles) pass at evaluation time.nix build '.#"go-1.26"'succeeds and builds Go from the 1.26.11 source tarball.go versionfrom the built module reportsgo version go1.26.11 linux/amd64.go version <gopls binary>).go run .with the new Go works.Rollout
Ships with the next bundle publish. Existing published bundles are not changed. Reverting this PR restores Go 1.25 cleanly, no data or state is involved.
Not ticked: users on Go 1.25 and older move to Go 1.26 (see the heads up above).
~ written by ⠕ Replit