Skip to content

Build the remaining Go tools with the patched Go 1.26.11 (CVE-2026-97040) - #522

Merged
akramhussein merged 2 commits into
mainfrom
akram/go-1.26.11-remaining-builds
Nov 19, 2026
Merged

akramhussein merged 2 commits into
mainfrom
akram/go-1.26.11-remaining-builds

Conversation

@akramhussein

Copy link
Copy Markdown
Contributor

Why

Go has a critical bug in its build tool, CVE-2026-97040: building a package that contains a specially crafted .syso file can sneak extra flags into the linker. It is fixed only in Go 1.26.11 and 1.27.4.

An earlier change moved the Go module and gopls to the patched Go 1.26.11. A few other tools in this repo are also written in Go and were still compiled with older Go versions that do not have the fix. This PR builds them with the same patched Go 1.26.11.

What changed

All of these are now built with the patched Go 1.26.11 that the Go module already uses:

  • python-wrapped, the small launcher that ships in every Python module. It was built with the default Go from nixpkgs.
  • hermit and the Databricks CLI. They were also built with the default Go from nixpkgs.
  • The Docker module:
    • The runc, containerd, BuildKit and Moby forks were pinned to Go 1.21.
    • The Docker client, Compose and Buildx came prebuilt with Go 1.22 from an older nixpkgs. They are now rebuilt here from the same source versions.

No tool changes version. The Docker module still builds everything from its own pinned nixpkgs. Only the Go compiler is swapped.

Test plan

  • Compared the output path of every module, for both development and deployment, before and after. Only these change: databricks-cli, docker, hermit-0.38.2, python-3.8 to python-3.12, python-base-3.11 to python-base-3.13 and python-with-prybar-3.10. Nothing is added or removed.
  • Built all of the changed modules. Every Go binary in them now reports go1.26.11 when checked with go version <binary>.
  • Docker module: ran the version command of each rebuilt binary (docker --version, docker compose version, docker buildx version, runc, containerd, ctr, the runc shim, buildctl, buildkitd and dockerd). All of them start and print their version.
  • Not tested: starting a container with the rebuilt Docker module. The forks need the Replit container runtime, which was not available where this was built.
  • nix fmt -- --check . passes.

Rollout

The Docker module's forks are old (runc 1.1.9, containerd 1.7.5, Moby 24.0.7) and jump from Go 1.21 to Go 1.26. They build and start, but nobody has run a container with them yet. Please try the Docker module in a real Repl before this is released.

If that turns up a problem, the second commit (Docker module) can be dropped on its own. The first commit does not depend on it.

  • This is fully backward and forward compatible

Chat about this change

~ written by ⠕ Replit

These were still compiled with the default Go from nixpkgs, which does
not have the fix for CVE-2026-97040. They now use the same patched Go
1.26.11 that the Go module and gopls already use.

Assisted-by: Replit
The Docker module's runc, containerd, BuildKit and Moby forks were
pinned to Go 1.21, and the Docker client, Compose and Buildx came
prebuilt with Go 1.22 from an older nixpkgs. None of those Go versions
has the fix for CVE-2026-97040. They are now all built with the patched
Go 1.26.11.

Assisted-by: Replit
@akramhussein
akramhussein requested a review from vlinkz November 19, 2026 17:19
@akramhussein akramhussein self-assigned this Nov 19, 2026
@akramhussein
akramhussein marked this pull request as ready for review November 19, 2026 17:24
@akramhussein
akramhussein requested a review from a team as a code owner November 19, 2026 17:24
@akramhussein
akramhussein requested a review from ryantm November 19, 2026 17:35
@akramhussein
akramhussein merged commit 05b00be into main Nov 19, 2026
9 checks passed
@akramhussein
akramhussein deleted the akram/go-1.26.11-remaining-builds branch November 19, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants