Repository navigation
Build the remaining Go tools with the patched Go 1.26.11 (CVE-2026-97040) - #522
Merged
Merged
Conversation
These were still compiled with the default Go from nixpkgs, which does not have the fix for CVE-2026-97040. They now use the same patched Go 1.26.11 that the Go module and gopls already use. Assisted-by: Replit
The Docker module's runc, containerd, BuildKit and Moby forks were pinned to Go 1.21, and the Docker client, Compose and Buildx came prebuilt with Go 1.22 from an older nixpkgs. None of those Go versions has the fix for CVE-2026-97040. They are now all built with the patched Go 1.26.11. Assisted-by: Replit
ryantm
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Go has a critical bug in its build tool, CVE-2026-97040: building a package that contains a specially crafted
.sysofile can sneak extra flags into the linker. It is fixed only in Go 1.26.11 and 1.27.4.An earlier change moved the Go module and gopls to the patched Go 1.26.11. A few other tools in this repo are also written in Go and were still compiled with older Go versions that do not have the fix. This PR builds them with the same patched Go 1.26.11.
What changed
All of these are now built with the patched Go 1.26.11 that the Go module already uses:
python-wrapped, the small launcher that ships in every Python module. It was built with the default Go from nixpkgs.hermitand the Databricks CLI. They were also built with the default Go from nixpkgs.No tool changes version. The Docker module still builds everything from its own pinned nixpkgs. Only the Go compiler is swapped.
Test plan
databricks-cli,docker,hermit-0.38.2,python-3.8topython-3.12,python-base-3.11topython-base-3.13andpython-with-prybar-3.10. Nothing is added or removed.go1.26.11when checked withgo version <binary>.docker --version,docker compose version,docker buildx version, runc, containerd, ctr, the runc shim, buildctl, buildkitd and dockerd). All of them start and print their version.nix fmt -- --check .passes.Rollout
The Docker module's forks are old (runc 1.1.9, containerd 1.7.5, Moby 24.0.7) and jump from Go 1.21 to Go 1.26. They build and start, but nobody has run a container with them yet. Please try the Docker module in a real Repl before this is released.
If that turns up a problem, the second commit (Docker module) can be dropped on its own. The first commit does not depend on it.
~ written by ⠕ Replit