Repository navigation
Report divisors that don't fit into 16 bits instead of panicking - #85
Merged
Merged
Conversation
calc_divisor() panicked for baud rates too low for the 16-bit divisor latch, e.g., when init() is called with such a configuration. Return an error instead. As NonIntegerDivisorError can't express this, introduce InvalidDivisorError.
Its InvalidBaudRate payload changes in this release, which is breaking anyway. Mark it non_exhaustive, so future variants won't be.
phip1611
force-pushed
the
divisor-errors
branch
from
October 10, 2026 18:11
4199492 to
fe4ff51
Compare
phip1611
marked this pull request as ready for review
October 10, 2026 18:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calc_divisor()panicked for baud rates too low for the 16-bit divisor latch, e.g., ininit(). It now returns the newInvalidDivisorError, which also covers non-integer divisors.calc_divisor()andInitError::InvalidBaudRateuseInvalidDivisorError.InitErroris#[non_exhaustive].🤖 Generated with Claude Code