Repository navigation
fix(opcua): run a fault manager in the OpenPLC tank demo - #683
Merged
bburda merged 0 commit intoNov 17, 2026
Merged
Conversation
bburda
force-pushed
the
fix/opcua-demo-runs-a-fault-manager
branch
from
November 17, 2026 08:47
90b3ddf to
7bfc266
Compare
bburda
force-pushed
the
fix/persist-entity-freeze-frames
branch
from
November 17, 2026 08:49
b4bf815 to
016a68e
Compare
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The plugin's
start.shstarted OpenPLC and one gateway container and no fault manager, so the demo the README describes could not confirm a fault:GET /api/v1/faultsanswered 503ListFaults service not available, and a PLC alarm waited in the plugin's report buffer for a service that never came.start.shnow runsfault_manager_nodein the gateway container beforegateway_node, waits for/fault_manager/report_fault, and logs it to/var/lib/ros2_medkit/fault_manager.log. The fault manager's state sits under/var/lib/ros2_medkit, the named volume from #680, so faults, freeze frames and recordings survivestop.shandstart.shtogether. The image is unchanged.test_all.sh, the test scripts and the CI workflow are untouched.Stacked on #680.
Issue
Type
Testing
Shell and docs only, so the evidence is the demo run, base against branch.
Base:
start.sh,GET /api/v1/faultsanswers 503ListFaults service not available. Drivingtank_temperatureto 95 raises the alarm onx-plc-statusand the fault list stays empty, nofaults.dbon the volume.Branch:
GET /api/v1/faultsanswers 200. The same write confirmsPLC_HIGH_TEMPwithin 2 s, and the fault detail carries afreeze_framewithtank_temperatureat 95. Afterstop.shandstart.shthe same detail is served with the samecaptured_atwhile the live PLC reads 25 °C. After the documented purge the fault is gone and the list is empty.Injected failure: a directory in place of
faults.dbmakes the fault manager abort, andstart.shexits 1 naming the missing service and printing the log tail.shellcheckandpre-commitpass.Checklist