Repository navigation
fix(fault_manager): a healed root cause ends its symptoms - #795
Open
mfaferek93 wants to merge 1 commit into
Open
mfaferek93 wants to merge 1 commit into
mfaferek93 wants to merge 1 commit into
Conversation
A fault that heals now leaves the correlation state like a cleared one. A healed root clears its symptoms under auto_clear_with_root, and a healed symptom leaves the muted list and its root's symptom list.
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
A root cause that healed through PASSED reports left its symptoms muted under a cause that was no longer on the list. A fault that heals now leaves the correlation state the same way a cleared one does.
auto_clear_with_root. The root's end event carriesauto_cleared_codes, as on a clear. Withoutauto_clear_with_rootthe symptoms are unmuted and show up in the list.muted_countis no longer stale.clear_faultand of healing is one helper. If the storage drops out in the middle, the event names only the symptoms that were cleared.A reporter can already heal any code it names with PASSED, so the cascade on heal gives it nothing new. Per-entity DELETE still skips the cascade.
Issue
Type
Testing
New
test_fault_manager_core_correlation(5 cases on the ROS-free core) and one new case intest_correlation_engine.colcon test --packages-select ros2_medkit_fault_manageron Jazzy: 964 tests, 0 failures. clang-format-18 is clean on the changed files.Checklist