Skip to content

fix(fault_manager): a healed root cause ends its symptoms - #795

Open
mfaferek93 wants to merge 1 commit into
mainfrom
fix/heal-root-clears-symptoms
Open

mfaferek93 wants to merge 1 commit into
mainfrom
fix/heal-root-clears-symptoms

Conversation

@mfaferek93

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

A root cause that healed through PASSED reports left its symptoms muted under a cause that was no longer on the list. A fault that heals now leaves the correlation state the same way a cleared one does.

  • A healed root cause clears its symptoms when the rule has auto_clear_with_root. The root's end event carries auto_cleared_codes, as on a clear. Without auto_clear_with_root the symptoms are unmuted and show up in the list.
  • A healed symptom leaves the muted list, so muted_count is no longer stale.
  • A cleared or healed symptom is removed from its root's symptom list. A later recurrence outside the window is independent and is not cleared with the old root.
  • A FAILED report that leaves a fault HEALED (hysteresis) is not correlated, so it cannot be muted again while it is not active.
  • The symptom cascade of clear_fault and of healing is one helper. If the storage drops out in the middle, the event names only the symptoms that were cleared.

A reporter can already heal any code it names with PASSED, so the cascade on heal gives it nothing new. Per-entity DELETE still skips the cascade.


Issue


Type

  • Bug fix
  • New feature or tests
  • Breaking change
  • Documentation only

Testing

New test_fault_manager_core_correlation (5 cases on the ROS-free core) and one new case in test_correlation_engine. colcon test --packages-select ros2_medkit_fault_manager on Jazzy: 964 tests, 0 failures. clang-format-18 is clean on the changed files.


Checklist

  • Breaking changes are clearly described (and announced in docs / changelog if needed)
  • Tests were added or updated if needed
  • Docs were updated if behavior or public API changed

A fault that heals now leaves the correlation state like a cleared one. A healed root clears its symptoms under auto_clear_with_root, and a healed symptom leaves the muted list and its root's symptom list.
Copilot AI balanced review requested due to automatic review settings November 18, 2026 11:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] A healed root cause leaves its symptoms muted

2 participants