Repository navigation
fix(integration_tests): call sigemptyset/sigaddset unqualified - #803
Merged
Merged
Conversation
On macOS, sigemptyset() and sigaddset() are also defined as macros in <signal.h>, so the qualified calls in install_crash_backtrace() expand to `::(...)` and fail to compile with Apple clang: error: expected unqualified-id Call them unqualified, which works with both the macro and the function. Tested on macOS 27 (arm64), Apple clang 21.0.0: the qualified calls fail with the error above, the unqualified ones compile. Built in the ros2_macOS jazzy CI run https://github.com/idesign0/ros2_macOS/actions/runs/44117826051. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>
bburda
approved these changes
Nov 20, 2026
bburda
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for the contribution and for testing it on macOS!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
On macOS,
sigemptyset()andsigaddset()are also defined as macros in<signal.h>. The qualified calls::sigemptyset(...)/::sigaddset(...)ininstall_crash_backtrace()(ros2_medkit_integration_tests/crash_backtrace.hpp) therefore expand to::(...)and fail to compile with Apple clang:This PR calls them unqualified, which works with both the macro and the function. No behaviour change.
Issue
No issue opened for this; it is a 4-line build fix. Happy to open one if you need it for tracking.
Type
Testing
macOS 27 (arm64), Apple clang 21.0.0 (clang-2100.3.34.2):
::sigemptyset(&set)/::sigaddset(&set, SIGSEGV)expected unqualified-idsigemptyset(&set)/sigaddset(&set, SIGSEGV)ros2_medkit_integration_testswith this change, ros2_macOS CI (ROS 2 Jazzy)Not tested on Linux, where both forms compile. I'm relying on CI there.
Did you use Generative AI? Yes: Claude Code (Claude Opus 5.5) found the cause, wrote the change and ran the tests above. I reviewed the change and the results.
Checklist
🤖 Generated with Claude Code