Repository navigation
fix(gateway): record all topics in the bringup preset - #804
Open
mfaferek93 wants to merge 1 commit into
Open
mfaferek93 wants to merge 1 commit into
mfaferek93 wants to merge 1 commit into
Conversation
A fault that comes through a bridge was recorded with the bridge's own topics only, so a /diagnostics fault got a bag with /diagnostics and nothing about the robot. The preset now sets snapshots.rosbag.topics to "all". Sensor topics stay excluded.
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bringup_params.yamlnow setssnapshots.rosbag.topics: all. The parameter default staysentity.Why
The bringup preset is what a new user runs: no manifest, faults come from the bridges. In
entitymode the fault manager writes the topics of the node that reported the fault. For a bridged fault that node is the bridge, so the bag holds the bridge's topics and nothing about the robot.Seen on a real robot (ROS 2 Humble, image
ros2_medkit-humble:0.7.1,enable_diagnostic_bridge:=true). The camera driver publishes an ERROR on/diagnostics, the diagnostic bridge reports it, and the log says:Same fault, same robot, three runs:
/diagnostics,/tf_static/diagnosticssnapshots.rosbag.topics: all, full pre-rollWith
allthe bag has odometry, both lidars, IMU, battery, joystick, camera info and the fault events. Image and point cloud topics stay out, becausesnapshots.rosbag.exclude_sensor_topicsis on by default.The fault manager already subscribes to every topic for the pre-roll in
entitymode, so this changes what is written to disk, not what is buffered.Not in this PR
entitymode. A user who setsentityon purpose gets the same small bag for a/diagnosticsfault. That needs its own fix: either fall back to the full buffer when the reporter is a bridge, or let the bridge name the node the fault is about.Testing
Run on the robot with a copy of
bringup_params.yamlthat has this one line added, passed throughparams_file:=. Numbers above are from that run. No automated test covers the preset file today.