Skip to content

fix(gateway): record all topics in the bringup preset - #804

Open
mfaferek93 wants to merge 1 commit into
mainfrom
fix/bringup-record-all-topics
Open

mfaferek93 wants to merge 1 commit into
mainfrom
fix/bringup-record-all-topics

Conversation

@mfaferek93

Copy link
Copy Markdown
Collaborator

Summary

bringup_params.yaml now sets snapshots.rosbag.topics: all. The parameter default stays entity.

Why

The bringup preset is what a new user runs: no manifest, faults come from the bridges. In entity mode the fault manager writes the topics of the node that reported the fault. For a bridged fault that node is the bridge, so the bag holds the bridge's topics and nothing about the robot.

Seen on a real robot (ROS 2 Humble, image ros2_medkit-humble:0.7.1, enable_diagnostic_bridge:=true). The camera driver publishes an ERROR on /diagnostics, the diagnostic bridge reports it, and the log says:

Entity scope for fault 'CAMERA_TEMPERATURES': 3 topic(s) from the faulting node(s) + /tf

Same fault, same robot, three runs:

Run Bag length Bag size Topics in the bag
preset as it is, fault 1.7 s after start 2.0 s 12 KB /diagnostics, /tf_static
preset as it is, full pre-roll 5.2 s 20 KB /diagnostics
snapshots.rosbag.topics: all, full pre-roll 6.0 s 0.46 MB 10 topics, 671 messages

With all the bag has odometry, both lidars, IMU, battery, joystick, camera info and the fault events. Image and point cloud topics stay out, because snapshots.rosbag.exclude_sensor_topics is on by default.

The fault manager already subscribes to every topic for the pre-roll in entity mode, so this changes what is written to disk, not what is buffered.

Not in this PR

  • The scope for a bridged fault is still the bridge in entity mode. A user who sets entity on purpose gets the same small bag for a /diagnostics fault. That needs its own fix: either fall back to the full buffer when the reporter is a bridge, or let the bridge name the node the fault is about.
  • No changelog entry. It goes in with the next release PR.

Testing

Run on the robot with a copy of bringup_params.yaml that has this one line added, passed through params_file:=. Numbers above are from that run. No automated test covers the preset file today.

A fault that comes through a bridge was recorded with the bridge's own
topics only, so a /diagnostics fault got a bag with /diagnostics and
nothing about the robot. The preset now sets snapshots.rosbag.topics
to "all". Sensor topics stay excluded.
Copilot AI balanced review requested due to automatic review settings November 19, 2026 15:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants