Require Admin Credentials Outside Development/Test Environments - #277
Open
jarednorman wants to merge 3 commits into
Open
jarednorman wants to merge 3 commits into
jarednorman wants to merge 3 commits into
Conversation
The seed used to fall back to the documented admin@example.com / test123 credentials in every environment, so a database seeded in production or staging without ADMIN_EMAIL and ADMIN_PASSWORD set got a fully privileged admin account with publicly known credentials. Keep the defaults for development and test, where the sandbox, the docs and extension test suites rely on them, and abort with instructions everywhere else.
The --admin-email, --admin-password and --interactive options passed the credentials to railties:install:migrations, which never creates a user, so they had no effect. Run spree_auth:admin:create after migrating when either option is given. Callers that pass neither are unchanged.
tvdeyen
approved these changes
Oct 4, 2026
adammathys
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No one should be using the defaults outside of dev/test, so I've made it bail out if you try to. Included a couple other little minor fixes.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed:
🤖 Generated with Claude Code