Skip to content

fix: match RHEL 7 request order default - #404

Closed
damacus wants to merge 1 commit into
mainfrom
fix/php-235-rhel7
Closed

damacus wants to merge 1 commit into
mainfrom
fix/php-235-rhel7

Conversation

@damacus

@damacus damacus commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

The RHEL 7 template now sets request_order = "GP", matching the Red Hat package default and excluding cookies from $_REQUEST. Caller directives can still override it.

Red Hat’s public RHEL 7Server PHP source RPM contains the installed php.ini as Source2; it sets GP. That entire file has the same SHA-256 as php.ini in the CentOS 7 build source for 5.4.16-48. The Red Hat source inspected is the 2015 alternate-architecture build; the later Red Hat-signed source was not independently inspected.

ChefSpec covers the RHEL 7 default and override. Local validation: 31 examples passed; Cookstyle passed (18 files).

Fixes #235.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@damacus
damacus requested a review from a team as a code owner November 12, 2026 22:04
@github-actions

Copy link
Copy Markdown

Slowest examples

Top 10 slowest examples (0.99 seconds, 55.01% of total time)
Example Description Time in seconds
spec/resource_actions_spec.rb:152 PHP custom resource actions when declaring a PEAR installation is expected to install build_essential "" 0.12858
spec/resource_actions_spec.rb:225 PHP custom resource actions when upgrading a PEAR package upgrades to the current stable version 0.12473
spec/php_ini_spec.rb:42 php_ini on Red Hat 7 is expected to render file "/etc/php.ini" 0.12323
spec/php_ini_spec.rb:67 php_ini on CentOS 7 is expected to render file "/etc/php.ini" 0.11868
spec/resource_actions_spec.rb:19 PHP custom resource actions when installing PHP is expected to add php_ini "ini" 0.10989
spec/php_ini_spec.rb:18 php_ini on Red Hat 9 is expected to render file "/etc/php.ini" 0.09719
spec/php_ini_spec.rb:79 php_ini on CentOS 8 is expected to render file "/etc/php.ini" 0.07701
spec/php_ini_spec.rb:30 php_ini on Red Hat 8 is expected to render file "/etc/php.ini" 0.07483
spec/php_ini_spec.rb:55 php_ini on Red Hat 7 with an override is expected to render file "/etc/php.ini" 0.07361
spec/php_ini_spec.rb:91 php_ini on CentOS 9 is expected to render file "/etc/php.ini" 0.07214

@damacus damacus closed this Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recipe missing request_order

1 participant