Skip to content

ListQueueBroker crashes on a real Redis connection drop instead of retrying #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juneja-varun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ListQueueBroker crashes on a real Redis connection drop instead of retrying #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions taskiq_redis/redis_broker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,14 @@
TypeVar,
)

from redis.asyncio import BlockingConnectionPool, Connection, Redis, ResponseError
from redis.asyncio import (
BlockingConnectionPool,
Connection,
ConnectionError,
Redis,
ResponseError,
TimeoutError,
)
from taskiq import AckableMessage
from taskiq.abc.broker import AsyncBroker
from taskiq.abc.result_backend import AsyncResultBackend
Expand Down Expand Up @@ -133,7 +140,7 @@ async def listen(self) -> AsyncGenerator[bytes, None]:
if brpop_result is None:
continue
yield brpop_result[redis_brpop_data_position] # type: ignore[misc]
except ConnectionError as exc:
except (ConnectionError, TimeoutError) as exc:
logger.warning("Redis connection error: %s", exc)
continue

Expand Down
10 changes: 10 additions & 0 deletions tests/test_broker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,16 @@ async def test_pub_sub_broker_max_connections(
await broker.shutdown()


@pytest.mark.anyio
async def test_list_queue_broker_retries_on_connection_error() -> None:
"""Test that listen() retries on a redis ConnectionError instead of raising."""
broker = ListQueueBroker(url="redis://localhost:1/0")
gen = broker.listen()

with pytest.raises(asyncio.TimeoutError):
await asyncio.wait_for(gen.__anext__(), timeout=0.5)


@pytest.mark.anyio
async def test_list_queue_broker(
valid_broker_message: BrokerMessage,
Expand Down