Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coming from PR comments in temporalio/sdk-dotnet#908 and from something I found in a code review. It is a follow-up to PRs #3075 and #3084.
These are issues in the original PR this was modeled from so needs to get spread back to the other SDKs.
The change looks big but really isn't - cleaned up comments, and changed how some things are being passed around, but those just touched a good handful of places.
Breaking (experimental API): NexusClientCallsInterceptor.GetNexusOperationResultInput now takes a single nullable NexusSerializationContext instead of separate endpoint, service and operation strings. getSerializationContext() replaces getEndpoint(), getService() and getOperation(). The three values could be set independently, which needed a runtime all-or-nothing check. With one context, a partially set result input can no longer be built. NexusOperationHandleImpl now stores one context, and UntypedNexusServiceClientImpl.start builds it once for both the input payload and the handle.
Fix: with the use-existing ID conflict policy, the server can return an already-running operation that was started with a different endpoint, service or operation than the request names. The handle used to take its context from the request, so it decoded results under the wrong context. When the start response reports started=false, the client now describes the operation and uses the endpoint, service and operation from the description.
Comments: removed doc comments that promised downstream decoding behavior. Also fixed a wrong comment on NexusTaskHandler.Result: servers before 1.30 give a context with an empty endpoint, not a null context.