Repository navigation
dht: capture response and data in one critical section - #911
Open
StanislavNikolov wants to merge 1 commit into
Open
StanislavNikolov wants to merge 1 commit into
StanislavNikolov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first DHT22 read on an ESP32 could fail with
checksum mismatchwhile subsequent reads succeeded.waitForDataTransmissionreturns when the sensor starts the first data bit's low pulse. The subsequent call toreceiveSignalsand its interrupt setup consume part of that pulse. Since decoding compares each high pulse with its preceding low pulse, this can leave the first bit close to the decision boundary.Wait for the sensor response inside
receiveSignals, after disabling interrupts, then capture the data immediately. ReturnNoSignalErroron response timeouts and restore interrupts on every exit. Remove the unused response-wait helper.Validation:
make testpassed, including formatting, unit tests, and all smoke builds.esp32-coreboard-v2with-opt=1 -no-debug.-opt=1 -no-debug.