Repository navigation
machine/stm32: use the generated TIM and ADC SQ1 constants - #6115
Open
davecheney wants to merge 1 commit into
Open
davecheney wants to merge 1 commit into
davecheney wants to merge 1 commit into
Conversation
Contributor
Author
|
/cc @bemasher |
The TIM per-channel constants and the U5 ADC SQ1 position were wrong because gen-device-svd placed dimensioned bitfields wrong, so the drivers hard-coded the hardware values. With the fix in tinygo-org#5821 the generated values match the hardware in every STM32 device file that a target uses. This reverts commit 82f4fcf and the U5 ADC workaround. This must merge after tinygo-org#5821. The pwm and adc examples build to identical binaries on 11 boards with tinygo-org#5821 applied.
davecheney
force-pushed
the
stm32-svd-workarounds
branch
from
October 31, 2026 02:36
ce8d84b to
48844c1
Compare
davecheney
marked this pull request as ready for review
October 31, 2026 02:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TIM per-channel constants and the U5 ADC SQ1 position were wrong because gen-device-svd placed dimensioned bitfields wrong, so the drivers hard-coded the hardware values. With the fix in #5821 the generated values match the hardware in every STM32 device file that a target uses. This reverts commit 82f4fcf and the U5 ADC workaround.
This must merge after #5821. The pwm and adc examples build to identical binaries on 11 boards with #5821 applied.