non-boring-notes:0.1.1 - #5819
martincanga wants to merge 10 commits into
Conversation
|
@aruzdh You released non-boring-notes:0.1.0, so you probably want to have a look at this pull request. If you want this update to be merged, please leave a comment stating so. Without your permission, the pull request will not be merged. |
|
@aruzdh You released non-boring-notes:0.1.0, so you probably want to have a look at this pull request. If you want this update to be merged, please leave a comment stating so. Without your permission, the pull request will not be merged. |
|
@aruzdh You released non-boring-notes:0.1.0, so you probably want to have a look at this pull request. If you want this update to be merged, please leave a comment stating so. Without your permission, the pull request will not be merged. |
|
@aruzdh You released non-boring-notes:0.1.0, so you probably want to have a look at this pull request. If you want this update to be merged, please leave a comment stating so. Without your permission, the pull request will not be merged. |
1 similar comment
|
@aruzdh You released non-boring-notes:0.1.0, so you probably want to have a look at this pull request. If you want this update to be merged, please leave a comment stating so. Without your permission, the pull request will not be merged. |
|
Hi, @martincanga! Thank you for contributing—just a small suggestion. We usually map "Tema" to "Topic", whereas "Unidad" is used for "Unit". We could easily add both: Unit -> Unidad; Topic -> Tema (if you want to use "Tema"). Feel free to update the PR if that works for you, or let me know what you think :] |
|
Hi, @aruzdh ! That makes complete sense. I'll update the PR to follow that mapping (Unit -> Unidad and Topic -> Tema). Thanks for the feedback! |
|
@aruzdh You released non-boring-notes:0.1.0, so you probably want to have a look at this pull request. If you want this update to be merged, please leave a comment stating so. Without your permission, the pull request will not be merged. |
|
@aruzdh You released non-boring-notes:0.1.0, so you probably want to have a look at this pull request. If you want this update to be merged, please leave a comment stating so. Without your permission, the pull request will not be merged. |
|
@aruzdh Sorry for the repeated pings, the bot is a bit dumb here. Still, I would like you to double-check that the changes corresponds to what you asked for. Also, in case you didn't already do it, it would be best to backport this new version to your own repository, so that future contributors can keep building on it. |
|
No worries at all, @elegaanz. Thanks for the heads-up :) @martincanga thanks for adding both! Just one tiny fix: in unit, the English and Spanish values got swapped; en is currently set to "Unidad" and es to "Unit". |
|
@aruzdh You released non-boring-notes:0.1.0, so you probably want to have a look at this pull request. If you want this update to be merged, please leave a comment stating so. Without your permission, the pull request will not be merged. |
|
@aruzdh You released non-boring-notes:0.1.0, so you probably want to have a look at this pull request. If you want this update to be merged, please leave a comment stating so. Without your permission, the pull request will not be merged. |
|
Thank you @aruzdh for spotting that! Thanks again for being so thorough :) |

I am submitting
Description: Adds the term 'unit' (and its corresponding translation) to the h1_heading so class notes can be easily organized by unit.