Repository navigation
feat(stovepipe): implement List controller and pagination - #785
Merged
Merged
Conversation
mnoah1
force-pushed
the
mnoah1/stovepipe-list-query-readability
branch
from
October 6, 2026 18:54
d383c1f to
04b2167
Compare
mnoah1
changed the title
mnoah1
force-pushed
the
mnoah1/stovepipe-list-query-readability
branch
from
October 6, 2026 18:56
04b2167 to
9022492
Compare
mnoah1
added this pull request to stack #783
October 6, 2026 18:58
mnoah1
force-pushed
the
mnoah1/stovepipe-list-query-readability
branch
4 times, most recently
from
October 6, 2026 20:50
fbffa7a to
df0321c
Compare
Base automatically changed from
mnoah1/stovepipe-list-acceptance-mapping
to
main
October 6, 2026 20:51
mnoah1
force-pushed
the
mnoah1/stovepipe-list-query-readability
branch
from
October 6, 2026 20:51
df0321c to
6975278
Compare
mnoah1
commented
Oct 6, 2026
mnoah1
marked this pull request as ready for review
October 6, 2026 21:01
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 6, 2026 21:01
Summary: Build on #782 with queue-scoped List behavior: half-open acceptance windows, default page size 50 (maximum 200), versioned continuation tokens, and point reads of current request summaries. Tokens preserve the resolved window and bytewise ordering cursor across pages. Inconsistent mappings fail the page without partial results. RPC/server wiring remains a follow-up. ## Issue Links None — follow-up to the approved List API RFC (#775); no separate ticket. Test Plan: All 22 Stovepipe and service unit targets pass. make fmt gazelle lint check-tidy check-gazelle passes. Revert Plan: Revert this commit; no schema changes or exposed RPC behavior are introduced here. API Changes: Add the internal List request/result types and transport-independent controller.
mnoah1
added a commit
that referenced
this pull request
Oct 6, 2026
Summary: Wire the approved List RPC to the controller in #785. Preserve optional time-bound presence, map current request summaries to protobuf, and use the same configured queues as Ingest. Add mapper and handler coverage; end-to-end coverage remains a follow-up. Test Plan: All 22 Stovepipe and service unit targets pass. make fmt gazelle lint check-tidy check-gazelle passes. Revert Plan: Revert this commit to leave List unimplemented again; existing RPCs and storage are unchanged. API Changes: Expose the existing List RPC. No protobuf or schema changes.
mnoah1
force-pushed
the
mnoah1/stovepipe-list-query-readability
branch
from
October 6, 2026 21:59
6975278 to
7ec48a5
Compare
behinddwalls
approved these changes
Oct 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 6, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the controller layer for Stovepipe’s List API:
Test Plan
All 22 Stovepipe and service unit targets pass. make fmt gazelle lint check-tidy check-gazelle passes.
Revert Plan
Revert this commit; no schema changes or exposed RPC behavior are introduced here.
API Changes
Add the internal List request/result types and transport-independent controller.