You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please include a summary of the changes and the related issue including relevant motivation and context. Please also include a link to the corresponding JIRA ticket this merge request addresses.
Contributors
Let's acknowledge the people who contributed to the work.
Type of change
Refactoring (made code better without changing its behaviour)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
How this has been tested
Please describe the tests that you ran to verify your changes.
If they are not automated tests please explain why and provide screenshots and/or instructions so they can reproduced.
Checklist
I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Reviewer Checklist
I have reviewed the PR and ensured no secret or sensitive values are present
Your PR has commits that are missing the Signed-off-by trailer, which is added by the pre-commit hooks. To install them, run pre-commit install --install-hooks --overwrite -t commit-msg -t pre-commit, or follow the instructions at https://github.com/uktrade/github-standards/blob/main/README.md#usage. If the commit was made in the GitHub web UI, installing the hooks will not help. Only applying suggested changes and updating the branch are allowed there, so make the change locally instead
Your PR has commits that are missing the Signed-off-by trailer, which is added by the pre-commit hooks. To install them, run pre-commit install --install-hooks --overwrite -t commit-msg -t pre-commit, or follow the instructions at https://github.com/uktrade/github-standards/blob/main/README.md#usage. If the commit was made in the GitHub web UI, installing the hooks will not help. Only applying suggested changes and updating the branch are allowed there, so make the change locally instead
Your PR has commits that are missing the Signed-off-by trailer, which is added by the pre-commit hooks. To install them, run pre-commit install --install-hooks --overwrite -t commit-msg -t pre-commit, or follow the instructions at https://github.com/uktrade/github-standards/blob/main/README.md#usage. If the commit was made in the GitHub web UI, installing the hooks will not help. Only applying suggested changes and updating the branch are allowed there, so make the change locally instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue including relevant motivation and context. Please also include a link to the corresponding JIRA ticket this merge request addresses.
Contributors
Let's acknowledge the people who contributed to the work.
Type of change
How this has been tested
Please describe the tests that you ran to verify your changes.
If they are not automated tests please explain why and provide screenshots and/or instructions so they can reproduced.
Checklist
Reviewer Checklist