Skip to content

Remote cache requests ignore Ctrl-C and fast-fail #766

Description

@wan9chi

While vp run is looking a task up in the remote cache, downloading its outputs, or uploading its results, pressing Ctrl-C doesn't interrupt the request. Neither does another task failing when fast-fail is on. The run waits until the request finishes or times out, which can take a long time against a slow or unresponsive endpoint.

A lookup that finishes after Ctrl-C can still let the task go ahead: on a miss, the task's command starts after the user asked to stop, and on a hit, its outputs are restored into the workspace.

Expected: Ctrl-C and fast-fail stop remote cache requests promptly, and no task starts or restores its outputs after the run was cancelled.

Affects remote cache uploads (#755) and reads (#756).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions