test(cache): drop test server handling that tests never exercise - #758
Merged
Merged
Conversation
Tests run one wrapper at a time in each directory and never signal it, so remove signal handling, the usage error, blob ID checks, and the extra `command_wrapper` case. `cbor-http` always runs under the wrapper, so it appends its path to `VP_REMOTE_CACHE_URL` directly. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
wan9chi
added this pull request to stack #759
September 25, 2026 02:35
fspy benchmarklinuxmacoswindows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The remote cache test server from #754 handles cases the tests never hit: signals sent to the wrapper, a missing command, spawn failures, non-numeric blob IDs, and
cbor-httpcalls with an absolute URL or withoutVP_REMOTE_CACHE_URL. Test infra should only handle what the tests exercise.remote-cache-servernow starts the server, runs the command, closes the server, and exits with the command's exit code. The blob route and state loading check whether the file exists.cbor-httpalways appends its path toVP_REMOTE_CACHE_URL. Thecommand_wrappercase goes away; the other snapshots are unchanged.