Repository navigation
Reorder bench groups and SQL file size charts - #225
Merged
Merged
Conversation
- Groups: Compression and Compression Size, then SQL File Size, then Random Access and the query groups as before. String Encoding and String Encoding Size move to the end, after the groups sorted by name. - SQL File Size charts: clickbench, then tpch, then tpcds, then the other benchmarks by name, each by numeric scale factor. - TPC-H, TPC-DS and nested TPC-H charts always name their scale factor, so `tpch sf=1.0` sits beside `tpch sf=10.0`. - Bump the group payload cache version, since the cached order and names change. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniB9quRiv5fCx8AhzH9s Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔦 Lighthouse audit
Run |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
bench. This commit was pushed to the #222 branch nine minutes after #222 merged, so it never reached
main.Group order:
The string-bench groups come after everything else, from a new
GROUP_ORDER_LASTlist.SQL File Size chart order:
clickbench, thentpch, thentpcds, then the other benchmarks by name, each by numeric scale factor.Chart names: TPC-H, TPC-DS and nested TPC-H always name their scale factor, so
tpch sf=1.0sits besidetpch sf=10.0. Benchmarks without scale factors keep the plain name (clickbench).Cache:
GROUP_PAYLOAD_CACHE_VERSIONgoes fromv13tov14, because the cached group order and chart names change.How it was checked
bun run test:benchagainst a local PostgreSQL 16, on top ofmainat Link the site to its own deployment's bench outside production #224: 1004 passed, 9 skipped. The tests cover the group order with the string groups last, and the file-size chart order and names.bun run check:cipasses.Every commit is signed off (
git commit -s), for the DCO check.bun run check:cipasses.Each new image or other asset has an annotation in
REUSE.toml. (No new assets.)Generated by Claude Code