Repository navigation
test: cover untested wrapper behaviour - #83
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 84.68% 91.50% +6.82%
==========================================
Files 19 19
Lines 1319 1319
==========================================
+ Hits 1117 1207 +90
+ Misses 202 112 -90
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
passcod
marked this pull request as ready for review
November 11, 2026 03:45
…s it The Windows test file was never declared as a module, so it never ran; it now checks exit through a process handle, as the job tests do.
…wait pid_alive reports processes it can't inspect as dead, which on macOS is every process.
pid_alive reported the process as dead on macOS whether or not it was, so this test passed there without checking anything.
passcod
force-pushed
the
test/coverage-gaps
branch
from
November 11, 2026 03:46
26e193a to
5d60015
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Adds tests for behaviour that nothing exercised. Each one checks what the code does, rather than just running the lines.
wait_with_output: with only stderr piped, and with both streams piped. On Unix the both-streams test writes more than a pipe's buffer to each, stderr first, so a reader that waited on one stream at a time would deadlock. On Windows, where the fallback reads one stream after the other, the output stays small.KillOnDrop:into_inner()must leave the child running. The Windowskill_on_droptest was never declared as a module, so it never ran. It now checks exit through a process handle, as the job-object tests do, instead of relying onremoteprocess.CreationFlagswithoutJobObject: the flags must reach the process unchanged, which the test shows by the child staying suspended.ResetSigmask: a child spawned from a thread that blocksSIGUSR1must see no blocked signals. A control test checks that, without the wrapper, the child does inherit the block. Linux only, since it reads/proc/self/status.ProcessGroup::attach_to()andProcessGroupChild::pgid(): a command attached to a leader's group must end up in that group, and killing the group must take it down.KillOnDropon Unix: the existing test's dead check usedpid_alive(remoteprocess), which reports processes it can't inspect as dead. On macOS that's every process, so the test passed there without checking anything. It now useskill(pid, 0), and the newinto_innertest usestry_wait.