Skip to content

fix: update generated websocket proxy types - #5767

Merged
bjohansebas merged 2 commits into
mainfrom
fix/generated-websocket-proxy-types
Oct 17, 2026
Merged

bjohansebas merged 2 commits into
mainfrom
fix/generated-websocket-proxy-types

Conversation

@bjohansebas

@bjohansebas bjohansebas commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Summary

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Use of AI

Summary by CodeRabbit

  • Bug Fixes
    • Corrected type declarations so WebSocket proxy factories can return no handler. This avoids type errors when a proxy factory conditionally provides a handler, while preserving support for factories that return one.

@changeset-bot

changeset-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4848612

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6185619e-5002-44f9-8113-33e624e8fac9
📥 Commits

Reviewing files that changed from the base of the PR and between f97a12c and 4848612.

📒 Files selected for processing: 1
  • test/server/proxy-option.test.js

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Walkthrough

The private webSocketProxies field’s element type now allows a factory to return RequestHandler or undefined. The external WebSocket test sets the connection origin to the dev-server URL and rejects its setup promise when the socket emits an error.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 48486

The generated type matches the handled runtime behavior, and the WebSocket test still checks the echoed message while rejecting setup errors. No actionable merge risk is evident.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the WebSocket proxy type change. It does not mention the related test update, but the title need not cover every change.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bjohansebas
bjohansebas merged commit 9915359 into main Oct 17, 2026
14 checks passed
@bjohansebas
bjohansebas deleted the fix/generated-websocket-proxy-types branch October 17, 2026 17:31
@codecov

codecov Bot commented Oct 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.14%. Comparing base (dc9a72c) to head (4848612).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5767      +/-   ##
==========================================
- Coverage   95.15%   95.14%   -0.01%     
==========================================
  Files           6        6              
  Lines        4976     5009      +33     
==========================================
+ Hits         4735     4766      +31     
- Misses        241      243       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant