Repository navigation
Conversation
POST /portal/revoke_link shipped in the API on 2026-10-09 and reached the generated SDKs on 2026-10-15, but workos-node is not in the oagen SDK matrix, so its AdminPortal module stopped at generateLink. Mirror the Python resource: generateLink accepts externalUserId, and revokeLink revokes every link generated with that id for the organization and ends the portal sessions started from them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| describe('with an externalUserId', () => { | ||
| it('sends it as external_user_id', async () => { | ||
| fetchOnce(portalLinkResponse, { status: 201 }); | ||
|
|
||
| await workos.adminPortal.generateLink({ | ||
| intent: GenerateLinkIntent.SSO, | ||
| organization: 'org_01EHQMYV6MBK39QC5PZXHY59C3', | ||
| externalUserId: 'user_12345', | ||
| }); | ||
|
|
||
| expect(fetchBody()).toEqual({ | ||
| intent: GenerateLinkIntent.SSO, | ||
| organization: 'org_01EHQMYV6MBK39QC5PZXHY59C3', | ||
| external_user_id: 'user_12345', | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
🔍 Duplicate external user ID test
The earlier externalUserId test sends the same request and checks the same body. This copy adds no coverage.
Was this helpful? React with 👍 or 👎 to provide feedback.
| ? deserializeIntentOptions(response.intent_options) | ||
| : undefined, | ||
| adminEmails: response.admin_emails, | ||
| externalUserId: response.external_user_id, |
There was a problem hiding this comment.
🔍 New serializer mapping lacks fixture coverage
The GenerateLink round-trip fixture omits external_user_id, so its test never checks whether the new field survives serialization.
Was this helpful? React with 👍 or 👎 to provide feedback.
…the round-trip fixture Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
 [Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryAdds user-scoped Admin Portal link revocation.
No actionable issues found. Tests were inspected but not run. ajworkos explicitly acknowledged that the generated files are hand-edited intentionally because Node is not regenerated. Reviews (1) · Last reviewed commit: "test(admin-portal): Drop duplicated exte..." · Reviewed by Greptile |
1 participant
Description
POST /portal/revoke_linkshipped in the API on Oct 9 and reached the generated SDKs on Oct 15, but workos-node is not in the oagen SDK matrix, so its AdminPortal module stopped atgenerateLink. This mirrors the Python resource:generateLinkacceptsexternalUserId(sent asexternal_user_id).revokeLink({ organization, externalUserId })posts to/portal/revoke_linkand resolves toundefined, like the other void endpoints in this SDK.The admin-portal files carry an oagen "do not edit" header, but nothing regenerates them: Node is absent from
openapi-spec/.github/sdk-matrix.json, and the port PR (#1629) has been stale since August. Hand-edited on purpose.Documentation
The API reference's revoke_link page has snippets for every SDK except Node. I'll open the docs PR once this is released.
🤖 Generated with Claude Code