Skip to content

docs: fix dead yew.rs links in the crate docs - #4247

Open
farisbasha wants to merge 1 commit into
yewstack:masterfrom
farisbasha:docs-dead-yew-rs-links
Open

farisbasha wants to merge 1 commit into
yewstack:masterfrom
farisbasha:docs-dead-yew-rs-links

Conversation

@farisbasha

Copy link
Copy Markdown

Description

Three rustdoc links in the yew crate point to yew.rs pages that return 404:

  • Component::view docs: https://yew.rs/concepts/html
  • props! docs: https://yew.rs/concepts/components/properties
  • functional module docs: https://yew.rs/docs/next/concepts/function-components/introduction

They now point to docs/next/concepts/html, docs/next/concepts/function-components/properties and docs/next/concepts/function-components, matching the docs/next/... style already used for the html! link in lib.rs. All three new URLs return 200 (checked with curl). Docs only.

Prepared with an AI coding assistant.

Checklist

  • I have reviewed my own code
  • I have added tests (n/a, doc links only)

@github-actions

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 7332482):

https://yew-rs-api--pr4247-docs-dead-yew-rs-lin-ys1lfi0z.web.app

(expires Tue, 24 Nov 2026 10:31:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions

Copy link
Copy Markdown

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.462 ns      │ 2.744 ns      │ 2.465 ns      │ 2.474 ns      │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.484 ns      │ 3.032 ns      │ 2.492 ns      │ 2.509 ns      │ 100     │ 1000000000

@github-actions

Copy link
Copy Markdown

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 100.038 100.038 0 0.000%
boids 164.864 164.864 0 0.000%
communication_child_to_parent 93.570 93.570 0 0.000%
communication_grandchild_with_grandparent 105.854 105.854 0 0.000%
communication_grandparent_to_grandchild 102.181 102.181 0 0.000%
communication_parent_to_child 90.967 90.967 0 0.000%
contexts 106.170 106.170 0 0.000%
counter 86.112 86.112 0 0.000%
counter_functional 88.154 88.154 0 0.000%
dyn_create_destroy_apps 90.023 90.023 0 0.000%
file_upload 98.432 98.432 0 0.000%
function_delayed_input 94.493 94.493 0 0.000%
function_memory_game 168.570 168.570 0 0.000%
function_router 401.388 401.388 0 0.000%
function_todomvc 164.869 164.869 0 0.000%
futures 236.709 236.709 0 0.000%
game_of_life 100.481 100.481 0 0.000%
immutable 259.451 259.451 0 0.000%
inner_html 80.653 80.653 0 0.000%
js_callback 109.634 109.634 0 0.000%
keyed_list 176.186 176.186 0 0.000%
mount_point 84.137 84.137 0 0.000%
nested_list 112.575 112.575 0 0.000%
node_refs 91.640 91.640 0 0.000%
password_strength 1768.016 1768.016 0 0.000%
portals 93.449 93.449 0 0.000%
router 367.591 367.591 0 0.000%
suspense 113.826 113.826 0 0.000%
timer 88.384 88.384 0 0.000%
timer_functional 99.272 99.272 0 0.000%
todomvc 141.896 141.896 0 0.000%
two_apps 86.054 86.054 0 0.000%
web_worker_fib 136.119 136.119 0 0.000%
web_worker_prime 186.440 186.440 0 0.000%
webgl 82.783 82.783 0 0.000%

✅ None of the examples has changed their size significantly.

@github-actions

Copy link
Copy Markdown

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 269.055 269.900 269.340 0.257
Hello World 10 370.426 384.305 373.143 4.049
Function Router 10 21600.993 22169.499 21984.358 167.641
Concurrent Task 10 1005.224 1006.568 1006.213 0.385
Many Providers 10 795.678 828.783 809.318 12.787

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 268.998 269.280 269.160 0.083
Hello World 10 367.190 407.518 374.037 12.346
Function Router 10 21765.721 22297.540 22011.711 148.442
Concurrent Task 10 1005.226 1006.406 1006.044 0.434
Many Providers 10 795.957 822.314 804.923 10.071

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant