Skip to content

fix(paramlist): pass through all args in span-based ParamValue calls - #5631

Merged
lgritz merged 1 commit into
AcademySoftwareFoundation:mainfrom
jinhgkim:param
Oct 30, 2026
Merged

lgritz merged 1 commit into
AcademySoftwareFoundation:mainfrom
jinhgkim:param

Conversation

@jinhgkim

Copy link
Copy Markdown
Collaborator

Stumbled across a few minor bugs while working on another PR. Nothing in the repo called these overloads yet, so none of this was caught.

Assisted-by: Claude Code / Opus 5.5

Stumbled across a few minor bugs while working on another PR. Nothing in
the repo called these overloads yet, so none of this was caught.

Assisted-by: Claude Code / Opus 5.5

Signed-off-by: Jinnie Kim <jinhgkim@gmail.com>

@lgritz lgritz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catches

@lgritz
lgritz merged commit 1c4811c into AcademySoftwareFoundation:main Oct 30, 2026
31 checks passed
@jinhgkim
jinhgkim deleted the param branch November 4, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants