Skip to content

fix(paramlist): pass through all args in span-based ParamValue calls #5631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgritz merged 1 commit into from
Oct 30, 2026
Merged

fix(paramlist): pass through all args in span-based ParamValue calls #5631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/include/OpenImageIO/paramlist.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,14 @@ class OIIO_UTIL_API ParamValue {
ParamValue(ustring name, TypeDesc type, int nvalues, cspan<std::byte> value,
Copy copy = Copy(true), Interp interp = INTERP_CONSTANT) noexcept
{
init_noclear(name, type, nvalues, value, copy);
init_noclear(name, type, nvalues, interp, value, copy);
}

ParamValue(string_view name, TypeDesc type, int nvalues,
cspan<std::byte> value, Copy copy = Copy(true),
Interp interp = INTERP_CONSTANT) noexcept
{
init_noclear(ustring(name), type, nvalues, value, copy);
init_noclear(ustring(name), type, nvalues, interp, value, copy);
}

// Deprecated versions that take raw pointers ////////////////////////
Expand Down Expand Up @@ -205,7 +205,8 @@ class OIIO_UTIL_API ParamValue {
span<T> value, Copy copy = Copy(true)) noexcept
{
clear_value();
init_noclear(ustring(name), type, nvalues, interp, value, copy);
init_noclear(ustring(name), type, nvalues, interp,
OIIO::as_bytes(value), copy);
}

// Deprecated versions that take raw pointers ////////////////////////
Expand Down Expand Up @@ -807,8 +808,8 @@ class OIIO_UTIL_API ParamValueSpan : public cspan<ParamValue> {
OIIO_DASSERT(BaseTypeFromC<T>::value == type.basetype
&& type.size() == value.size_bytes());
// Just call the untyped bytes version underneath.
return getattribute(name, type, as_writable_bytes(value),
casesensitive);
return getattribute_indexed(name, index, type, as_writable_bytes(value),
casesensitive);
}
bool getattribute_indexed(string_view name, int index, TypeDesc type,
span<std::byte> value,
Expand Down
Loading