Skip to content

ci: use shared signing setup action - #303

Merged
sreya merged 3 commits into
mainfrom
use-shared-signing-setup
Nov 19, 2026
Merged

sreya merged 3 commits into
mainfrom
use-shared-signing-setup

Conversation

@sreya

@sreya sreya commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Replaces the in-tree signing setup in release-sign.yml with the actions from coder/setup-apple-signing-action.

Refs coder/setup-apple-signing-action#1

@sreya
sreya marked this pull request as ready for review November 19, 2026 23:15
@sreya
sreya requested a review from a team November 19, 2026 23:15
@sreya
sreya requested a review from ethanndickson as a code owner November 19, 2026 23:15
@sreya
sreya merged commit bb2062d into main Nov 19, 2026
6 checks passed
@sreya
sreya deleted the use-shared-signing-setup branch November 19, 2026 23:18
@linear-code

linear-code Bot commented Nov 20, 2026

Copy link
Copy Markdown

SEC-1636

yermakoffivan pushed a commit to yermakoffivan/mux that referenced this pull request Nov 20, 2026
…8189)

Part of [MUX-419](https://linear.app/codercom/issue/MUX-419). Follows
coder#8178.

## Summary

`_sign-macos.yml` now takes `rcodesign` and the Cloud KMS signing setup
from
[`coder/setup-apple-signing-action`](https://github.com/coder/setup-apple-signing-action),
the action that coder/coder, coder/coder-desktop-macos and
coder/coder-desktop-windows use. The pin is the same commit as theirs.

## Background

coder#8178 built `rcodesign` with
`coder/coder-desktop-macos/.github/actions/install-rcodesign`.
coder/coder-desktop-macos#303 removed that action when the shared
repository replaced it, so the pin here names a commit that is not on
that repository's `main`. It still resolves, but nothing maintains it.

## Implementation

- **Build job:** `coder/setup-apple-signing-action/rcodesign` builds the
same `apple-platform-rs` revision with the same Rust toolchain and the
same PKCS#11 patch as the old action. Its `path` and `sha256` outputs
replace the fixed path and the checksum step.
- **Sign job:** `coder/setup-apple-signing-action` replaces the step
that installed `libkmsp11` and the half of the next step that wrote the
certificate. It installs the same `libkmsp11` 1.9 archive by the same
sha256, checks the certificate and prints its subject and serial number,
and writes the library configuration. `Sign` reads the three paths from
its outputs.

These parts stay in this repository: the two jobs with the sha256
handover, the refusal of a commit that is not on `main`, the
notarization key check, the Google Cloud sign-in, the throwaway path,
and the sign, notarize and staple steps.

One behaviour changes: when the certificate or the key ring is missing
or malformed, the error names the action input (`certificate-pem`,
`key-ring`), not the secret.

## Validation

- This PR's CI builds `rcodesign` with the new action and signs with it
in the throwaway chain.
- The setup action runs only on the release-key path, so its first run
here is the first push to `main` after the merge.
coder/coder-desktop-macos runs the same commit of it with its release
key.

## Risks

The same as coder#8178: a fault on the release-key path fails `main`'s macOS
build, and nothing publishes from it. PR and merge-queue runs do not use
that path.

---

_Generated with `xum` • Model: `anthropic:claude-fable-5-2` • Thinking:
`xhigh`_

<!-- mux-attribution: model=anthropic:claude-fable-5-2 thinking=xhigh
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants