Repository navigation
fix: don't wait for edxapp health before syncing requirements - #238
Merged
Merged
Conversation
provision-lms.sh started lms/cms with `docker compose up --wait` before installing requirements from the bind-mounted edx-platform checkout. The edxapp images are built nightly, so when edx-platform merges code that needs a newer package (e.g. manage.py importing openedx_filters.management.filters, which needs openedx-filters>=3.16.0), runserver crashes on import, the container never becomes healthy, and provisioning fails before reaching the step that would install the missing package. Start the containers without --wait (exec only needs them running), and wait for health only after requirements are installed and the containers restarted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rahulkanneri-2u
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Provisioning tests failed for every
*+lmsjob (e.g. run 42019632992) with:Root cause
edxops/lms-dev:latestis built nightly (04:00 UTC, Mon–Fri) fromedx/edx-platform@release-ulmorequirements, while CI bind-mounts a fresh edx-platform checkout over it.75694d42f(merged 2026-11-05 10:12 UTC) mademanage.pyimportopenedx_filters.management.filtersand bumpedopenedx-filtersto>=3.16.0. The image built earlier that day still had3.14.0, so runserver crashed on import and/heartbeatnever responded.provision-lms.shalready installsrequirements/edx/base.txtfrom the checkout, which would fix that mismatch, but since feat: make dev.up wait until services are actually running #229 (4079ef3) it runsup --waitbefore that step, so provisioning fails first.Same devstack commit (
88787c5) passed on 2026-11-04 (LMS healthy in ~22s); the only difference on 11-05 was the new image digest plus the new edx-platform commit.Fix
lms/cmswithout--wait(we only need the containers running toexecinto them).docker compose up -d --wait --no-deps $appso provisioning still fails fast if the devserver can't actually serve, which keeps what feat: make dev.up wait until services are actually running #229 was for.