Skip to content

fix: don't wait for edxapp health before syncing requirements #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naincy128 merged 1 commit into from
Nov 6, 2026
Merged

fix: don't wait for edxapp health before syncing requirements #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions provision-lms.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,16 @@ cms_port=18010
./load-db.sh edxapp
./load-db.sh edxapp_csmh

# Bring edxapp containers online
# Bring edxapp containers online.
#
# Do NOT use --wait here: the edxapp image is built nightly from edx-platform's
# requirements, but the edx-platform code is bind-mounted from the local
# checkout. If the checkout depends on a package version newer than what the
# image has, runserver crashes on import and the container can never become
# healthy until the requirements below are installed. We only need the
# container running so we can `exec` into it.
for app in "${apps[@]}"; do
docker compose up -d --wait --no-deps $app
docker compose up -d --no-deps $app
done

# install git for both LMS and CMS
Expand All @@ -25,6 +32,12 @@ for app in "${apps[@]}"; do
docker compose restart $app
done

# Now that requirements match the checked-out code, make sure the devservers
# actually come up healthy before continuing.
for app in "${apps[@]}"; do
docker compose up -d --wait --no-deps $app
done

# Run edxapp migrations first since they are needed for the service users and OAuth clients
# Make migrate runs migrations for both lms and cms.
docker compose exec -T lms bash -e -c 'source /edx/app/edxapp/edxapp_env && make migrate'
Expand Down
Loading