Extract readTimespec helper in __syscall_utimensat. NFC - #27786
Merged
Merged
Conversation
sbc100
force-pushed
the
readTimespec
branch
from
September 26, 2026 01:38
e47f117 to
8f3bd31
Compare
sbc100
changed the title
guybedford
approved these changes
Sep 26, 2026
guybedford
left a comment
guybedford
left a comment
Collaborator
There was a problem hiding this comment.
AI generated review, may be incorrect
LGTM: the helper is behaviourally identical (same UTIME_NOW/UTIME_OMIT handling and ms computation; tv_sec is now read only when used, which is where the JS saving comes from).
sbc100
enabled auto-merge (squash)
September 26, 2026 01:42
Extract duplicated `timespec` reading logic in `__syscall_utimensat` into a local `readTimespec` helper function.
sbc100
force-pushed
the
readTimespec
branch
from
September 26, 2026 15:34
8f3bd31 to
4b0ffa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract duplicated
timespecreading logic in__syscall_utimensatinto a localreadTimespechelper function.