Skip to content

Extract readTimespec helper in __syscall_utimensat. NFC #27786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Sep 26, 2026
Merged

Extract readTimespec helper in __syscall_utimensat. NFC #27786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions src/lib/libsyscall.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,25 +1080,19 @@ var SyscallsLibrary = {
atime = now;
mtime = now;
} else {
var seconds = {{{ makeGetValue('times', C_STRUCTS.timespec.tv_sec, 'i53') }}};
var nanoseconds = {{{ makeGetValue('times', C_STRUCTS.timespec.tv_nsec, 'i32') }}};
if (nanoseconds == {{{ cDefs.UTIME_NOW }}}) {
atime = now;
} else if (nanoseconds == {{{ cDefs.UTIME_OMIT }}}) {
atime = null;
} else {
atime = (seconds*1000) + (nanoseconds/(1000*1000));
}
times += {{{ C_STRUCTS.timespec.__size__ }}};
seconds = {{{ makeGetValue('times', C_STRUCTS.timespec.tv_sec, 'i53') }}};
nanoseconds = {{{ makeGetValue('times', C_STRUCTS.timespec.tv_nsec, 'i32') }}};
if (nanoseconds == {{{ cDefs.UTIME_NOW }}}) {
mtime = now;
} else if (nanoseconds == {{{ cDefs.UTIME_OMIT }}}) {
mtime = null;
} else {
mtime = (seconds*1000) + (nanoseconds/(1000*1000));
function readTimespec(ptr) {
var tv_nsec = {{{ makeGetValue('ptr', C_STRUCTS.timespec.tv_nsec, 'i32') }}};
if (tv_nsec == {{{ cDefs.UTIME_NOW }}}) {
return now;
}
if (tv_nsec == {{{ cDefs.UTIME_OMIT }}}) {
return null;
}
var tv_sec = {{{ makeGetValue('ptr', C_STRUCTS.timespec.tv_sec, 'i53') }}};
return (tv_sec*1000) + (tv_nsec/(1000*1000));
}
atime = readTimespec(times);
mtime = readTimespec(times + {{{ C_STRUCTS.timespec.__size__ }}});
}
// null here means UTIME_OMIT was passed. If both were set to UTIME_OMIT then
// we can skip the call completely.
Expand Down
4 changes: 2 additions & 2 deletions test/codesize/test_codesize_hello_dylink_all.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"a.out.js": 270648,
"a.out.js": 270602,
"a.out.nodebug.wasm": 587959,
"total": 858607,
"total": 858561,
"sent": [
"IMG_Init",
"IMG_Load",
Expand Down
Loading