Skip to content

[MAINT] Remove skip markers because tests work again - #1781

Merged
PGijsbers merged 3 commits into
mainfrom
fix/1544
Oct 20, 2026
Merged

PGijsbers merged 3 commits into
mainfrom
fix/1544

Conversation

@PGijsbers

Copy link
Copy Markdown
Collaborator

We had issues with a flaky tests, at least partially due to a flaky server (#1544).
I tried to investigate but found that all tests currently work again.
While I can see some ways to improve the tests, I want to defer that until more PRs are merged that affect the same files to avoid needlessly complicated merge conflicts. At the same time, I'd like to re-enable the tests to bring back coverage.

@codecov-commenter

codecov-commenter commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.46%. Comparing base (b9967b8) to head (cd8702d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1781       +/-   ##
===========================================
- Coverage   81.08%   53.46%   -27.63%     
===========================================
  Files          63       63               
  Lines        5230     5230               
===========================================
- Hits         4241     2796     -1445     
- Misses        989     2434     +1445     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PGijsbers
PGijsbers requested a review from L-Agbaria October 20, 2026 08:24
@PGijsbers
PGijsbers merged commit c8e2aaf into main Oct 20, 2026
21 of 24 checks passed
@PGijsbers
PGijsbers deleted the fix/1544 branch October 20, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants