Repository navigation
test: add journeys for hardware wallet send and lnurl pay - #867
Merged
Merged
Conversation
This was referenced Oct 4, 2026
ovitrif
marked this pull request as ready for review
October 4, 2026 20:14
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ovitrif
requested review from
a team,
coreyphillips and
pwltr
and removed request for
a team and
jvsena42
October 4, 2026 20:14
ovitrif
enabled auto-merge
October 4, 2026 20:14
|
pwltr
approved these changes
Oct 5, 2026
coreyphillips
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs:
Description
hardware-wallet/send-onchain.xmlso that the user-facing on-chain Send flow funded and signed by a paired Trezor is covered: Recipient, Amount, Review, Sign With Device, Sent, then one outgoing hardware activity row and a lower hardware balance. The existing hardware journeys cover pairing, the detail screen, activity and Transfer To Spending; none walks the Send sheet from a hardware wallet.lnurl/pay-no-spending-balance.xmland a suite README so that pasting an LNURL-pay link into a wallet with no Lightning spending balance is covered: the app resolves the pay request from the LNURL server, shows the capacity warning and stays on the recipient options. The README describes thebitkit-dockerLNURL-pay fixture (stable pay metadata, an invoice callback that errors until switched healthy) and what is not covered.Out of Scope
journeys/lnurl: the failing and then recovering invoice callback needs a Lightning spending balance, which the journey environment cannot give an isolated stack; the suite README says so.journeys/hardware-wallet: passphrase-protected sends and the Bluetooth transport; the Send journey uses the Bridge transport like the rest of the suite.Design
N/A — no UI changes.
Preview
N/A — no user-visible changes.
QA Notes
Journeys
send-onchain.xml— a funded Bridge emulator pays 10 000 sats from the Send sheet, signs on the device and shows one outgoing hardware rowpay-no-spending-balance.xml— an LNURL-pay link with zero spending balance shows the capacity warning and opens no amount or review screenManual Tests
N/A
Automated Checks
N/A