Skip to content

test: add journeys for hardware wallet send and lnurl pay - #867

Merged
ovitrif merged 4 commits into
masterfrom
test/hw-send-lnurl-journeys
Oct 5, 2026
Merged

ovitrif merged 4 commits into
masterfrom
test/hw-send-lnurl-journeys

Conversation

@ovitrif

@ovitrif ovitrif commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

Refs:

Description

  • Adds hardware-wallet/send-onchain.xml so that the user-facing on-chain Send flow funded and signed by a paired Trezor is covered: Recipient, Amount, Review, Sign With Device, Sent, then one outgoing hardware activity row and a lower hardware balance. The existing hardware journeys cover pairing, the detail screen, activity and Transfer To Spending; none walks the Send sheet from a hardware wallet.
  • Adds lnurl/pay-no-spending-balance.xml and a suite README so that pasting an LNURL-pay link into a wallet with no Lightning spending balance is covered: the app resolves the pay request from the LNURL server, shows the capacity warning and stays on the recipient options. The README describes the bitkit-docker LNURL-pay fixture (stable pay metadata, an invoice callback that errors until switched healthy) and what is not covered.
  • Gives the LNURL capacity warning toast an accessibility identifier so that the journey asserts on an identifier instead of translated text.

Out of Scope

  • journeys/lnurl: the failing and then recovering invoice callback needs a Lightning spending balance, which the journey environment cannot give an isolated stack; the suite README says so.
  • journeys/hardware-wallet: passphrase-protected sends and the Bluetooth transport; the Send journey uses the Bridge transport like the rest of the suite.

Design

N/A — no UI changes.

Preview

N/A — no user-visible changes.

QA Notes

Journeys

  • new send-onchain.xml — a funded Bridge emulator pays 10 000 sats from the Send sheet, signs on the device and shows one outgoing hardware row
  • new pay-no-spending-balance.xml — an LNURL-pay link with zero spending balance shows the capacity warning and opens no amount or review screen

Manual Tests

N/A

Automated Checks

N/A

@ovitrif ovitrif self-assigned this Oct 3, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-04T20:17:53.509457Z e0e44a4 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ovitrif
ovitrif requested review from a team, coreyphillips and pwltr and removed request for a team and jvsena42 October 4, 2026 20:14
@ovitrif
ovitrif enabled auto-merge October 4, 2026 20:14
@greptile-apps

greptile-apps Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Adds test journeys for hardware wallet and LNURL payment flows.

This PR appears safe to merge; no actionable defects were found.

What we checked:

  • Send uses the hardware wallet: The tab bar passes the current hardware wallet ID into SendConfig.
  • The keypad enters sats: The default display is modern Bitcoin. That input path reads the digits directly as sats.

Summary

Adds journeys for a hardware-wallet on-chain send and an LNURL-pay refusal with no spending balance.

  • Adds LnurlPayNoCapacityToast so the warning can be found by identifier.
  • Updates Bridge build instructions and documents funding and fixture requirements.
  • No actionable issues were found. The journeys were not run during this review.

Reviews (1) · Last reviewed commit: "test: correct the send and lnurl journey..."

@ovitrif
ovitrif merged commit a088951 into master Oct 5, 2026
35 of 36 checks passed
@ovitrif
ovitrif deleted the test/hw-send-lnurl-journeys branch October 5, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants