Repository navigation
Link the site to its own deployment's bench outside production - #224
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
joseph-isaacs
enabled auto-merge (squash)
November 13, 2026 14:57
The site's links to bench named https://bench.vortex.dev everywhere, so on a preview they left the deployment for production bench. benchHref() names bench.vortex.dev on production and the deployment's /bench elsewhere, from VERCEL_ENV, which next.config.mjs now embeds so the client-side header agrees with the server render. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniB9oN8dyJ9ch4n7Tw62 Signed-off-by: Claude <noreply@anthropic.com>
joseph-isaacs
force-pushed
the
ji/awesome-hypatia-yfqizp
branch
from
November 13, 2026 14:57
580d27d to
31414a1
Compare
🔦 Lighthouse audit
Run |
3 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
vortex.dev: the site's links to bench named
https://bench.vortex.devon every deployment, so on a Vercel preview they left the preview for production bench, though the preview serves its own bench at/bench.benchHref()(src/lib/bench-link.ts) now picks the link fromVERCEL_ENV:https://bench.vortex.devon production, the deployment's own/bencheverywhere else (previews, local builds). Nothing redirects: each build writes the right link. It is used by the header's Benchmarks link (src/lib/nav.ts), the homepage results table's source link and the FAQ's bench links (src/lib/faq.ts).next.config.mjsembedsVERCEL_ENVat build time, so the client-side header agrees with the server render.The results-table parity test swaps the vendored design-system renderer's hardcoded production href for
benchHref(), the one deliberate difference. The smoke specs accept either form of the link, so they pass on production and elsewhere.Not changed: on a preview, bench's links back to the site (Blog, the wordmark) still name
https://vortex.dev.How it was checked
bun run test: 228 pass, including the newtests/unit/bench-link.test.ts.bun run check:ci,tsc --noEmitandbun run knippass.bun run buildwithoutVERCEL_ENV: the built homepage and FAQ link to/benchand/bench/methodology.VERCEL_ENV=production bun run build: they link tohttps://bench.vortex.dev,https://bench.vortex.dev/andhttps://bench.vortex.dev/methodology.I did not run the Playwright smoke specs locally.
Every commit is signed off (
git commit -s), for the DCO check.bun run check:cipasses.Each new image or other asset has an annotation in
REUSE.toml. (None added.)🤖 Generated with Claude Code
https://claude.ai/code/session_01UeniB9oN8dyJ9ch4n7Tw62