Repository navigation
feat(rxquery): add rxqueryWith to cancel the terminal query operators - #27
Open
xperiandri wants to merge 1 commit into
Open
xperiandri wants to merge 1 commit into
xperiandri wants to merge 1 commit into
Conversation
The query operators that return a task (`count`, `head`, `iter`, ...)
called the R3 operators without a token, so a query over a hot source
could not be cancelled and kept its subscription alive. `RxQueryBuilder`
now carries a `CancellationToken` that every such operator observes;
`rxquery` keeps using `CancellationToken.None` and
`(rxqueryWith ct) { ... }` passes a token.
The `Builders` module opens `System.Threading` for the token instead of
repeating the file-level `open System`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 5, 2026
This was referenced Oct 5, 2026
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Cancellation tokens are consistently forwarded, and the parameterless builder preserves existing behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Adds opt-in cancellation for task-returning reactive query operators while preserving existing rxquery behavior.
Changes:
- Adds
rxqueryWithand a token-awareRxQueryBuilderconstructor. - Forwards cancellation tokens to all task-returning query operators.
- Documents the new API and adds a changelog entry.
| File | Description |
|---|---|
| src/FSharp.Control.R3/Observable.fs | Adds token-aware builders, cancellation forwarding, and API documentation. |
| CHANGELOG.md | Records the new cancellation support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Part of splitting #22 into small pull requests that can be reviewed one at a time. It is stacked on #26 (
fix/rxquery-sum-by-seed), so it shows only its own change; merge #26 first.The query operators that return a task (
count,head,iter, ...) called the R3 operators without a token, so a query over a hot source could not be cancelled and kept its subscription alive.RxQueryBuildernow carries aCancellationTokenthat every such operator observes:rxquerykeeps usingCancellationToken.None, and(rxqueryWith ct) { ... }passes a token. TheBuildersmodule opensSystem.Threadingfor the token instead of repeating the file-levelopen System.Types of changes
What types of changes does your code introduce to FSharp.Control.R3?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Tests (in #22):
BuilderTests.fs– rxqueryWith cancels head and unsubscribes from the source when its token is cancelled, rxqueryWith passes its token to every query operator that returns a task and RxQueryBuilder exposes its token while rxquery uses an uncancellable token.Stack – every pull request is based on the one before it, so each shows only its own change. Merge them in this order:
AwaitOperationConfigurationcases withAwait#23 refactor!: prefixAwaitOperationConfigurationcases withAwaitmapAsyncoptions eagerly #24 fix: validate the concurrency limit ofmapAsyncoptions eagerlyyield/zerosynchronously to keep element order #25 fix(rxquery): emityield/zerosynchronously to keep element ordersumBywithUnchecked.defaultof#26 fix(rxquery)!: stop seedingsumBywithUnchecked.defaultofrxqueryWithto cancel the terminal query operators #27 feat(rxquery): addrxqueryWithto cancel the terminal query operators ← this pull requestofSeqreachable asObservable.ofSeq#29 feat(observable)!: makeofSeqreachable asObservable.ofSeqObservable.choosetake avoptionchooser, addObservableOption#30 feat(observable)!: makeObservable.choosetake avoptionchooser, addObservableOptionchunkByBoundariesfor boundaries of any element type #31 feat(observable): addchunkByBoundariesfor boundaries of any element typecancellationTokenfromtoLookup#35 fix(async)!: remove the ignoredcancellationTokenfromtoLookupiterAsyncthroughForEachAsyncinstead ofCountAsync#37 fix: wait foriterAsyncthroughForEachAsyncinstead ofCountAsynciterAsyncreliably and never lose a failure of its action #38 fix: stopiterAsyncreliably and never lose a failure of its actionofTaskconfigureAwaittotrue#39 fix(task)!: defaultofTaskconfigureAwaittotruetoArrayandtoListinto theTask.Observablemodule #40 feat(task)!: movetoArrayandtoListinto theTask.Observablemodulebind,catchandmapAsync#42 docs: document the R3 1.3.1 limitations ofbind,catchandmapAsync🤖 Generated with Claude Code