Repository navigation
test: categorize the tests per tested component - #43
Open
xperiandri wants to merge 1 commit into
Open
xperiandri wants to merge 1 commit into
xperiandri wants to merge 1 commit into
Conversation
As in FSharp.Azure.Cosmos, every test class carries a self-sufficient `TestCategoryBaseAttribute` from `TestCategories.fs`, so a subset runs with `--filter TestCategory=...` without a separate string constant: `ProcessingOptions`, `Observable`, `Chunk`, `Builder`, `Async`, `Task`, `MapAsync` (also `Async` and `Task`, because every mapAsync test runs both flavours) and `Integration`. The two existing test classes get their categories now; the test classes of the integration suite get theirs as they are added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 5, 2026
This was referenced Oct 5, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The Async category filter omits an existing test of the Async-flavour length function.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds component-based MSTest filtering to FSharp.Control.R3, preparing for the expanded test suite in #22.
Changes:
- Defines eight category attributes, including shared Async/Task categories for MapAsync.
- Tags existing test classes and compiles category definitions first.
- Documents the new category file.
| File | Description |
|---|---|
| tests/FSharp.Control.R3.Tests/TestCategories.fs | Defines component category attributes. |
| tests/FSharp.Control.R3.Tests/ObservableTests.fs | Adds the Observable category. |
| tests/FSharp.Control.R3.Tests/FSharp.Control.R3.Tests.fsproj | Compiles categories before tests. |
| tests/FSharp.Control.R3.Tests/BuilderTests.fs | Adds the Builder category. |
| .github/copilot-instructions.md | Documents the category file in the project layout. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| [<TestClass; ObservableTestCategory>] | ||
| type ObservableTests () = | ||
|
|
||
| [<TestMethod>] |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed Changes
Part of splitting #22 into small pull requests that can be reviewed one at a time. It is stacked on #42 (
docs/r3-limitations), so it shows only its own change; merge #42 first.As in FSharp.Azure.Cosmos, every test class carries a self-sufficient
TestCategoryBaseAttributefromTestCategories.fs, so a subset runs with--filter TestCategory=...without a separate string constant:ProcessingOptions,Observable,Chunk,Builder,Async,Task,MapAsync(alsoAsyncandTask, because everymapAsynctest runs both flavours) andIntegration.Types of changes
What types of changes does your code introduce to FSharp.Control.R3?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
The two existing test classes get their categories here; #22 tags the test classes it adds.
Stack – every pull request is based on the one before it, so each shows only its own change. Merge them in this order:
AwaitOperationConfigurationcases withAwait#23 refactor!: prefixAwaitOperationConfigurationcases withAwaitmapAsyncoptions eagerly #24 fix: validate the concurrency limit ofmapAsyncoptions eagerlyyield/zerosynchronously to keep element order #25 fix(rxquery): emityield/zerosynchronously to keep element ordersumBywithUnchecked.defaultof#26 fix(rxquery)!: stop seedingsumBywithUnchecked.defaultofrxqueryWithto cancel the terminal query operators #27 feat(rxquery): addrxqueryWithto cancel the terminal query operatorsofSeqreachable asObservable.ofSeq#29 feat(observable)!: makeofSeqreachable asObservable.ofSeqObservable.choosetake avoptionchooser, addObservableOption#30 feat(observable)!: makeObservable.choosetake avoptionchooser, addObservableOptionchunkByBoundariesfor boundaries of any element type #31 feat(observable): addchunkByBoundariesfor boundaries of any element typecancellationTokenfromtoLookup#35 fix(async)!: remove the ignoredcancellationTokenfromtoLookupiterAsyncthroughForEachAsyncinstead ofCountAsync#37 fix: wait foriterAsyncthroughForEachAsyncinstead ofCountAsynciterAsyncreliably and never lose a failure of its action #38 fix: stopiterAsyncreliably and never lose a failure of its actionofTaskconfigureAwaittotrue#39 fix(task)!: defaultofTaskconfigureAwaittotruetoArrayandtoListinto theTask.Observablemodule #40 feat(task)!: movetoArrayandtoListinto theTask.Observablemodulebind,catchandmapAsync#42 docs: document the R3 1.3.1 limitations ofbind,catchandmapAsync🤖 Generated with Claude Code