Repository navigation
docs: document the R3 1.3.1 limitations of bind, catch and mapAsync - #42
Open
xperiandri wants to merge 1 commit into
Open
xperiandri wants to merge 1 commit into
xperiandri wants to merge 1 commit into
Conversation
…ync` The integration tests that follow in this series exposed R3 1.3.1 defects that the library cannot work around without reimplementing the operators, so the docs state them where they apply: - `bind`: an inner failure after the source completed is ignored, so the result completes without it, or never completes when it was the last inner sequence running (Cysharp/R3#401). - `catch`: disposing the result after it switched to the handler's sequence leaves that sequence subscribed (Cysharp/R3#400). - `mapAsync`, both flavours: a failure after the source completed is dropped (Cysharp/R3#377), an `OperationCanceledException` is never reported and stops the sequential modes (Cysharp/R3#399), and every failure of a limited `AwaitSequentialParallel` leaks a slot (Cysharp/R3#397); `iterAsync` is not affected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 5, 2026
This was referenced Oct 5, 2026
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation accurately reflects the referenced R3 1.3.1 defects and follows the project’s XML documentation conventions.
Review effort: Balanced
Findings: None
What changed in this PR
Documents known R3 1.3.1 limitations affecting observable operators.
Changes:
- Documents
bindandcatchfailure/disposal defects. - Documents
mapAsyncfailure, cancellation, and concurrency-slot defects. - Updates the changelog.
| File | Description |
|---|---|
CHANGELOG.md |
Records the added limitation documentation. |
Observable.fs |
Documents bind and catch limitations. |
AsyncObservable.fs |
Documents Async mapAsync limitations. |
TaskObservable.fs |
Documents Task mapAsync limitations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Part of splitting #22 into small pull requests that can be reviewed one at a time. It is stacked on #41 (
docs/async-task), so it shows only its own change; merge #41 first.Documentation only. Writing the integration tests of #22 exposed R3 1.3.1 defects that the library cannot work around without reimplementing the operators, so the docs state them where they apply:
bind: an inner failure after the source completed is ignored, so the result completes without it, or never completes when it was the last inner sequence running –SelectManydrops an inner failure that arrives after the source completed Cysharp/R3#401.catch: disposing the result after it switched to the handler's sequence leaves that sequence subscribed –Catchdoes not unsubscribe from the handler's sequence when disposed Cysharp/R3#400.mapAsync, both flavours: a failure after the source completed is dropped (SelectAwait and SubscribeAwait do not properly propagate exception to UnhandledExceptionHandler Cysharp/R3#377), anOperationCanceledExceptionis never reported and stops the sequential modes (SelectAwait/SubscribeAwaitswallow everyOperationCanceledExceptionand stop the sequential modes for good Cysharp/R3#399), and every failure of a limitedAwaitSequentialParallelleaks a slot (SelectAwaitwithAwaitOperation.SequentialParallelandmaxConcurrentleaks a slot when the selector fails Cysharp/R3#397).Types of changes
What types of changes does your code introduce to FSharp.Control.R3?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
iterAsyncis not affected by themapAsynclimitations since #38.Stack – every pull request is based on the one before it, so each shows only its own change. Merge them in this order:
AwaitOperationConfigurationcases withAwait#23 refactor!: prefixAwaitOperationConfigurationcases withAwaitmapAsyncoptions eagerly #24 fix: validate the concurrency limit ofmapAsyncoptions eagerlyyield/zerosynchronously to keep element order #25 fix(rxquery): emityield/zerosynchronously to keep element ordersumBywithUnchecked.defaultof#26 fix(rxquery)!: stop seedingsumBywithUnchecked.defaultofrxqueryWithto cancel the terminal query operators #27 feat(rxquery): addrxqueryWithto cancel the terminal query operatorsofSeqreachable asObservable.ofSeq#29 feat(observable)!: makeofSeqreachable asObservable.ofSeqObservable.choosetake avoptionchooser, addObservableOption#30 feat(observable)!: makeObservable.choosetake avoptionchooser, addObservableOptionchunkByBoundariesfor boundaries of any element type #31 feat(observable): addchunkByBoundariesfor boundaries of any element typecancellationTokenfromtoLookup#35 fix(async)!: remove the ignoredcancellationTokenfromtoLookupiterAsyncthroughForEachAsyncinstead ofCountAsync#37 fix: wait foriterAsyncthroughForEachAsyncinstead ofCountAsynciterAsyncreliably and never lose a failure of its action #38 fix: stopiterAsyncreliably and never lose a failure of its actionofTaskconfigureAwaittotrue#39 fix(task)!: defaultofTaskconfigureAwaittotruetoArrayandtoListinto theTask.Observablemodule #40 feat(task)!: movetoArrayandtoListinto theTask.Observablemodulebind,catchandmapAsync#42 docs: document the R3 1.3.1 limitations ofbind,catchandmapAsync← this pull request🤖 Generated with Claude Code